refactor(kubernetes): Provider implementations deal with Manager instantiations#379
Merged
matzew merged 2 commits intocontainers:mainfrom Oct 20, 2025
Merged
Conversation
…antiations Removed `*Manager` parameter from `ProviderFactory`. Provider implementations should deal with the appropriate (base) Manager instantiation if needed at all. Manager creation function divided into two explicit functions: - NewKubeconfigManager: to be used when using KubeConfig files - NewInClusterManager: to be used inside a cluster New functions contain validations to ensure they are used in the expected places. This ensures that the right manager is used by the provider implementation. Fake kubeconfig for in-cluster Manager is now generated when the Manager is created. This kubeconfig has the "magic" strings (inClusterKubeConfigDefaultContext) that are used by the MCP server and tool mutators. Signed-off-by: Marc Nuri <marc@marcnuri.com>
Member
Author
|
This should be the last of the changes I had in mind for the Povider-Manager problem 😅 It breaks openshift#58 a little, but I think that it simplifies its ProviderFactory implementations since many of the checks won't be necessary :) |
matzew
reviewed
Oct 20, 2025
matzew
reviewed
Oct 20, 2025
Collaborator
|
LGTM me, overall I like the cleaner approach of this |
Signed-off-by: Marc Nuri <marc@marcnuri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
*Managerparameter fromProviderFactory.Provider implementations should deal with the appropriate (base) Manager instantiation if needed at all.
Manager creation function divided into two explicit functions:
New functions contain validations to ensure they are used in the expected places. This ensures that the right manager is used by the provider implementation.
Fake kubeconfig for in-cluster Manager is now generated when the Manager is created. This kubeconfig has the "magic" strings (inClusterKubeConfigDefaultContext) that are used by the MCP server and tool mutators.