feat(pods): add optional tail parameter to pod logs retrieval#335
Merged
manusa merged 3 commits intocontainers:mainfrom Sep 25, 2025
Merged
feat(pods): add optional tail parameter to pod logs retrieval#335manusa merged 3 commits intocontainers:mainfrom
manusa merged 3 commits intocontainers:mainfrom
Conversation
iamsudip
force-pushed
the
main
branch
2 times, most recently
from
9599fbc to
3ec7f1c
Compare
Contributor
Author
|
cc: @manusa |
manusa
approved these changes
Sep 23, 2025
Member
manusa
left a comment
manusa
left a comment
There was a problem hiding this comment.
LGTM
@ardaguclu can you please take a look
ardaguclu
reviewed
Sep 23, 2025
pkg/toolsets/core/pods.go
Outdated
Member
There was a problem hiding this comment.
structured output will eliminate all these manual casting. This is not ideal. But for now, I don't see any alternative way.
Member
There was a problem hiding this comment.
That should be the second step once we migrate to go-sdk
…t 256 lines Signed-off-by: iamsudip <sudip.maji@harness.io>
Contributor
Author
|
@ardaguclu @manusa I have addressed review comments. |
Signed-off-by: iamsudip <sudip.maji@harness.io>
iamsudip
changed the title
Member
|
Thank you, this PR looks good to me |
manusa
approved these changes
Sep 24, 2025
Member
manusa
left a comment
manusa
left a comment
There was a problem hiding this comment.
Code looks good, thx!
Tool schemas for validation need updating. I can do this for you if you want.
…t 256 lines Signed-off-by: Marc Nuri <marc@marcnuri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297