Signed v2s1 oci skip #84
Conversation
| err = ociDest.PutManifest([]byte(m)) | ||
| require.Error(t, err) | ||
| assert.Contains(t, `Unrecognized manifest media type: "application/vnd.docker.distribution.manifest.v1+prettyjws"`, err.Error()) | ||
| assert.Equal(t, `can't create an OCI manifest from Docker V2 schema 1 manifest`, err.Error()) |
There was a problem hiding this comment.
I think it's ok not to differentiate between signed and not-signed here
There was a problem hiding this comment.
Yes; the users don’t even want to know about schema versions, let alone the pointless signatures.
That’s a good point; OTOH the set of MIME types detected by |
you are right, fixing it! |
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
signed-v2s1-oci-skip
branch
from
38f9a6b to
e9c5a80
Compare
|
@mtrmac fixed PTAL |
|
lgtm |
|
👍, please merge after tests. |
Signed-off-by: Antonio Murdaca <[email protected]>
2 participants
alright @mtrmac this should be the right fix for containers/skopeo#198 - note that `GuessManifestMIMEType cannot actually return a meaningful string to be printed when the mime type isn't recognized so - we may just debug print the manifest.