copy: try list conversions on list push failures #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
reviewed
Feb 18, 2020
nalind
force-pushed
the
manifest-list-retry-using-conversions
branch
3 times, most recently
from
00b7353 to
17393e8
Compare
Member
|
@mtrmac PTAL |
nalind
force-pushed
the
manifest-list-retry-using-conversions
branch
3 times, most recently
from
c0cd64d to
9821654
Compare
nalind
force-pushed
the
manifest-list-retry-using-conversions
branch
from
9821654 to
4a936a6
Compare
mtrmac
reviewed
Mar 16, 2020
| // Iterate through supported list types, preferred format first. | ||
| c.Printf("Writing manifest list to image destination\n") | ||
| var errs []string | ||
| for _, thisListType := range append([]string{selectedListType}, otherManifestMIMETypeCandidates...) { |
Collaborator
There was a problem hiding this comment.
Non-blocking: Can/should this use ManifestTypeRejectedError to avoid unnecessary attempts (and duplicated error messages) for other kinds of failures?
OTOH right now we only have two types, so it’s not at all urgent.
Member
nalind
force-pushed
the
manifest-list-retry-using-conversions
branch
from
4a936a6 to
5e404aa
Compare
Member
|
Tests aren't happy: |
Similarly to how we fall back to trying to push single-image manifests in alternate formats when the original/preferred type is rejected by a registry, attempt to do the same for manifest lists. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
manifest-list-retry-using-conversions
branch
from
5e404aa to
062db46
Compare
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to how we fall back to trying to push single-image manifests in alternate formats when the original/preferred type is rejected by a registry, attempt to do the same for manifest lists.