Reset SystemContext.DockerAuthConfig when using mirrors at different registries #625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was brought up sometime during the reviews, but was apparently lost.
Consider
registries.conf:Then
currently sends the
foo:barto every mirror that requires authentication, not just toexample.com; that seems clearly undesirable.So, clear
SystemContext.DockerAuthConfigwhen using a mirror at a different registry than the one specified by the user; if the mirrors require credentials, they have to be set up in the auth file, e.g. bypodman login.@vrothberg @saschagrunert PTAL.
(#588 may be relevant for more discussion about
DockerAuthConfig)