Vendor in latest containers/storage

[rhatdan]

DefaultStorageOptions now is a function and takes a rootless argument
and the UID of root within the container.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

[rhatdan]

@mtrmac @vrothberg PTAL

[vrothberg]

Cross-compilation doesn't like the change:

vendor/github.com/containers/storage/utils.go:76:35: undefined: syscall.Stat_t
vendor/github.com/containers/storage/utils.go:85:35: undefined: syscall.Stat_t

I wonder how this passed containers/storage CI.

[rhatdan]

Hopefully containers/storage#306 will fix

[rhatdan]

@vrothberg updated

[vrothberg]

LGTM (assuming green tests)

[vrothberg]

I wonder why Travis takes soooo long to fire off here. @cevich, do you know what magic we need to make Travis a bit more responsive? Sometimes it takes 30 minutes or even more until the tests start after a push.

[TomSweeneyRedHat]

LGTM assuming happy tests

[cevich]

I wonder why Travis takes soooo long to fire off here

@vrothberg it needs dollar-bills (seriously). I don't like Travis. Can we not use it? Please? 😃

[vrothberg]

@rhatdan, builds are still not happy:

storage/storage_transport.go:183:41: multiple-value storage.DefaultStoreOptions() in single-value context

[rhatdan]

@giuseppe @vrothberg @mtrmac PTAL
Trying to work with skopeo to allow it to add/remove images from containers storage and to vendor in latest containers/storage.

containers/skopeo#620

[rhatdan]

@vrothberg @mtrmac Not sure how to get this to pass tests with skopeo. I did move this patch into skopeo and it builds.

[mtrmac]

@rhatdan This can’t pass in this repo; (the process is https://github.com/containers/skopeo/blob/master/CONTRIBUTING.md#dependencies-management ).

Looking at containers/skopeo#620, skopeo tests do pass there, so, merging. Please rebase containers/skopeo#620 on top of c/image master now, until then all other c/image PRs will fail.