pkg/docker/config: Deprecate GetUserLoggedIn

[wking]

And refactor it to use GetAuthentication, which is just as convenient for callers. This also removes the lookup differences between lookup logic between the two functions (e.g. GetUserLoggedIn used to ignore DockerAuthConfig).

Spun off from #588 here and #596.

[vrothberg]

Need to update containers/image to reflect the latest changes in containers/storage:

# github.com/containers/image/storage
storage/storage_image.go:735:55: not enough arguments in call to s.imageRef.transport.store.SetImageBigData
	have (string, string, []byte)
	want (string, string, []byte, func([]byte) (digest.Digest, error))

Code LGTM 👍 Thanks, @wking !

[mtrmac]

If we are doing this, I’d just remove the method; a logrus.Warn is not really wanted by the callers and it’s not actionably by end users.

I do need to check the earlier history of the code (notably #333 ), the different handling and/or the .docker fallback mentioned in #596 might actually have been intentional — I can’t remember any more.

[wking]

If we are doing this, I’d just remove the method...

I've pushed ee8c757 -> e64a79b, removing it.

I do need to check the earlier history of the code (notably #333 ), the different handling and/or the .docker fallback mentioned in #596 might actually have been intentional...

I checked, and saw no discussion in either the commit message or pull request that motivated the different lookup logic. You can obviously still check for yourself too ;).

[vrothberg]

@wking would you rebase, so we can merge it? Note that podman-login uses GetUserLoggedIn() and must be updated accordingly when we vendor containers/image over there (Cc @baude @mheon).

[rhatdan]

@wking ping...

[vrothberg]

I am updating this PR, so we can merge it.

[vrothberg]

Note to ourselves, we must update Podman (and Buildah?) afterward.

[vrothberg]

Fixes: #596

[vrothberg]

LGTM, @mtrmac @rhatdan PTAL

[rhatdan]

LGTM

[lio24]

I need window 10 to download docker on my PC