Move copy implementation into containers/image #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
copy
branch
5 times, most recently
from
19e7bec to
6e76a03
Compare
Merged
Collaborator
Author
|
Rebased to depend only on #64. |
Member
|
I'm reviewing code in the last commit 15a9bb7 |
| source io.Reader | ||
| digest hash.Hash | ||
| expectedDigest []byte | ||
| failureIndicator *bool |
Member
There was a problem hiding this comment.
just fail? I believe it's clear that it's indicating that by the bool (and pointer)
Collaborator
Author
There was a problem hiding this comment.
That reads wrong to me, I read verbs as method names.
The lazy way to deal with this is to say that this has not been modified from skopeo’s copy but that’s a poor excuse :)
Actually, this does not need to be a pointer at all, simply a bool validationFailed.
Still, for consistency I’d prefer moving the code as close to unmodified as possible, and I promise to fix that separately.
Member
|
LGTM (after questions) |
This uses code from projectatomic/skopeo, only stripping its CLI handling. Signed-off-by: Miloslav Trmač <[email protected]>
Collaborator
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we’ve discussed several times, this moves the core of
skopeo copyinto the library.Depends on way too much pending work, I will rebase as necessary.