Skip to content

Conversation

@jonboulle
Copy link
Contributor

No description provided.

@williammartin
Copy link

Hi @jonboulle, for the build .gitvalidation target to pass you'll need to add a DCO. Thanks!

@TomSweeneyRedHat
Copy link
Member

Change LGTM, just need to sign/DCO it. 'git commit --amend -s'

@jonboulle
Copy link
Contributor Author

oops, fixed

@rhatdan
Copy link
Member

rhatdan commented Oct 25, 2017

LGTM

@mtrmac
Copy link
Collaborator

mtrmac commented Oct 25, 2017

👍 Thanks!

Approved with PullApprove

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 6, 2017

Can you re-push this (e.g. change the commit message) to trigger CI again, please? It seems the test happened to run in the unlucky period between merging #328 and containers/skopeo#440.

@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2018

@jonboulle Could you rebase?
@runcom PTAL

@jonboulle
Copy link
Contributor Author

rebased

@rhatdan
Copy link
Member

rhatdan commented Jun 1, 2018

@jonboulle We finally got a version of this merged. Thanks for the PR. Sorry it took so long.

@rhatdan rhatdan closed this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants