Skip to content

Conversation

@bitoku
Copy link

@bitoku bitoku commented Aug 18, 2025

This PR adds PutSignaturesWithFormat/GetSignaturesWithFormat support to OCI layout.
The general idea is tag-based discovery, same as sigstore signature discovery.

It stores the signature with annotation org.opencontainers.image.ref.name: "sha256-<hash>.sig", which can be used as a tag. https://specs.opencontainers.org/image-spec/image-layout/#IMAGE-SPEC-IMAGE-LAYOUT-19

Please let me know what you think about this change. thanks

Signed-off-by: Ayato Tokubi <[email protected]>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a very brief skim for now; overall the code / structure looks reasonable… but the need to deal with updated config files change would make things more complex.

Note to self: compare https://github.com/containers/image/issues/2854 .

@bitoku
Copy link
Author

bitoku commented Aug 21, 2025

Thank you for the feedback! I will get back to this after some of my other urgent tasks are settled.

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 26, 2025

Hello @bitoku,

We’ve recently migrated this repository into a new monorepo: containers/container-libs along with other repositories

Could you move this PR to that repo, please? It should involve only re-applying the changes in an image/ subdirectory of the repo.

Let me know if you are facing any issues, I’d be happy to help with the logistics.

You can read more about the migration and the reasoning behind it in our blog post: Upcoming migration of three containers repositories to monorepo.

Thanks again!

@bitoku
Copy link
Author

bitoku commented Aug 26, 2025

@mtrmac Thank you for letting me know!
yeah I'll move this PR once I can get a good amount of time.
I'm still busy lately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants