docker/image_dest: ask for pull action in token scope #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After PR containers#202, PutBlob() now goes through an initial HasBlob() which may require authentication in order to perform the check; in such case a push-only scoped token will fail with: ``` service="registry.docker.io",scope="repository:<name>:pull",error="insufficient_scope" ``` This fixes the above case by changing the scope of the token requested for uploads, allowing pull+push. Signed-off-by: Luca Bruno <[email protected]>
Member
Author
lucab
force-pushed
the
ups/docker-dest-scope-pull-action
branch
from
77a3551 to
0062a02
Compare
Member
|
LGTM |
Collaborator
|
👍 Thanks! (Note to self: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #202, PutBlob() now goes through an initial HasBlob()
which may require authentication in order to perform the check;
in such case a push-only scoped token will fail with:
This fixes the above case by changing the scope of the token
requested for uploads, allowing pull+push.
Signed-off-by: Luca Bruno [email protected]