Tests for the X-Registry-Supports-Signatures extension #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
5 times, most recently
from
4055fcc to
ba1d0aa
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
859c64d to
936827d
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
3 times, most recently
from
faa0ff4 to
989ddcb
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
989ddcb to
0e44572
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
5 times, most recently
from
a3c6480 to
7400bf5
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
bc76afb to
748ff00
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
7084eda to
d798f69
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
3 times, most recently
from
7d4f00a to
ae3e3ce
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
3 times, most recently
from
0320ab0 to
c6561e5
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
48d6951 to
1304b5c
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
18def57 to
cf7cfcf
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
22b64f9 to
77af62a
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
34b2fb3 to
8cff7a2
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
8cff7a2 to
93160ce
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
a230533 to
bd2c852
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
bd2c852 to
d5905ef
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
d5905ef to
d32526b
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
d32526b to
4d2173a
Compare
Member
|
@mtrmac @vrothberg What should we do with this PR? Should we rebase and move forward or should we close it? |
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
4d2173a to
ed05ff5
Compare
Collaborator
Author
|
The discussion whether to do this at all should happen in #254. Until then, rebased. |
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
3 times, most recently
from
efadbf5 to
1929f0c
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
1929f0c to
a088df4
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
a088df4 to
c1733d6
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
2 times, most recently
from
c2e0b98 to
2b476f8
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
2b476f8 to
efe12a0
Compare
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
efe12a0 to
a35541c
Compare
…er, add an example This allows running the test against a live registry once, manually inspecting the requests/responses to be as expected, and then running all tests against a “recording” of the requests/responses, completely off-line. Also adds a simple test for GetManifest to demonstrate the use of the mechanism. The httpWrapper mechanism is intended purely for tests, and not intended to be exposed to external users; they should use types.SystemContext. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
… at the dockerClient helper level, and in the dockerImageSource case. Does not actually test all of dockerImageSource.GetSignatures (including the support autodetection). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
… primarily to test the supportsSignatures parsing, for now; also smoke-tests Bearer challenges and http/https detection. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
x-registry-supports-signatures-tests
branch
from
a35541c to
b23c3b0
Compare
Collaborator
Author
|
Not valuable enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on, and includes, #254 and #255 , and adds tests for the new functionality introduced in #255. This is split from #255 so that the “how to test the docker registry client” discussion is not blocking merging of the code.
See individual commit messages for a bit more detail.