Revert "manifest: remove not needed mediatype" #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
guess-oci-manifest-again
branch
from
e0be7cb to
94da9e7
Compare
This reverts commit 0a5f50d. , which broke tests. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
guess-oci-manifest-again
branch
from
94da9e7 to
92a5462
Compare
Member
ops, silly me, btw, that commit wasn't totally wrong, RC4 doesn't have mediatype in the manifest anymore so that |
Collaborator
Author
|
Honestly I don't want to be thinking about this now, and #241 is doing that anyway. This is just to get tests working (… assuming we can get past Travis; I’ve seen 2 runs fail with “unexpected EOF” in 2 different places.) |
Member
|
alright, lgtm |
Member
|
👍 |
Collaborator
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0a5f50d. ,
which broke tests.
Eventually we may need that commit (when updating
image-spec?), but right now it seems unnecessary and this is the most obvious way to get tests working without having to think :)