Skip to content

Conversation

@erikh
Copy link
Contributor

@erikh erikh commented Jan 24, 2017

This patch just replaces the k8s library with the one in
opencontainers/storage. Tests still pass and we can just fix that much easier
if we need to.

Signed-off-by: Erik Hollensbe <[email protected]>
@erikh
Copy link
Contributor Author

erikh commented Jan 24, 2017

Sorry I didn't see #225, if the k8s lib is still required feel free to close this.

giuseppe pushed a commit to giuseppe/image that referenced this pull request Jan 24, 2017
@mtrmac
Copy link
Collaborator

mtrmac commented Jan 24, 2017

Yeah, it would be nice to use a single package; sadly, the two have a bit different semantics. #225 tries to preserve the k8s semantics, but we’ll see whether that is acceptable for #207.

So let’s keep this open for a bit. Thanks for working on this!

@erikh
Copy link
Contributor Author

erikh commented Jan 24, 2017 via email

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 25, 2017

At this point it seems preferable for the OpenShift transport to clearly use OpenShift semantics, and for containers/storage to clearly use container/storage semantics, whatever they are and however they differ (or not).

Unifying the dependency would be nice in principle, but honestly the packages are small enough that not having to think about how they differ from the respective upstreams and whether/why that matters is simpler. (And they do matter somehow, otherwise everyone would just be doing os.user.Current().HomeDir instead of creating these packages.)

@erikh erikh closed this Feb 7, 2017
@erikh erikh deleted the openshift-kube-fix branch February 7, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants