Use docker/distribution/reference.ParseNormalizedNamed #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/distribution/reference.ParseNamed now (as of 6170ac53daed40ebbebc9fe5f482495d01f09f12) refuses input in a non-fully-explicit form; the new ParseNormalizedNamed accepts it and normalizes it into the fully explicit form. (One would expect it to be the other way around…) So, use ParseNormalizedNamed now. This is a minimal fix for the failing tests. Because docker/distribution/reference now does all the normalization, we can use it and drop our docker/docker/reference fork (which will go away upstream), at least in the short term. (Longer-term we may need to reintroduce it again if projectatomic/docker decided to modify _that_.) But that’s more than just fixing the tests, so that will be a separate PR. Signed-off-by: Miloslav Trmač <[email protected]>
Collaborator
Author
|
Corresponding skopeo PR: containers/skopeo#292 . |
Member
I believe this will be needed in any case in projectatomic/docker since that package is taking care of helping with the multiple registry story IIRC. |
Member
|
👍 |
Collaborator
Author
|
👍 |
This was referenced Jan 20, 2017
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Jan 24, 2017
…ture After containers#220, and especially future containers#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Jan 24, 2017
…ture After containers#220, and especially future containers#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Jan 30, 2017
…ture After containers#220, and especially future containers#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
Jamesjaj2dc6j
added a commit
to Jamesjaj2dc6j/lucascalsilvaa
that referenced
this pull request
Jun 6, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
mrhyperbit23z0d
added a commit
to mrhyperbit23z0d/thomasdarimont
that referenced
this pull request
Jun 6, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
easyriderk0c9g
added a commit
to easyriderk0c9g/rnin9
that referenced
this pull request
Jun 6, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
oguzturker8ijm8l
added a commit
to oguzturker8ijm8l/diwir
that referenced
this pull request
Jun 6, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
wesnowm
added a commit
to wesnowm/MatfOOP-
that referenced
this pull request
Jun 6, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
gaveen3
added a commit
to gaveen3/KimJeongHoon3x
that referenced
this pull request
Jun 6, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
gaveen3
added a commit
to gaveen3/KimJeongHoon3x
that referenced
this pull request
Jun 6, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
Manuel-Suarez-Abascal80n9y
added a commit
to Manuel-Suarez-Abascal80n9y/knimeu
that referenced
this pull request
Oct 7, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
straiforos8bsh5n
added a commit
to straiforos8bsh5n/tokingsq
that referenced
this pull request
Oct 7, 2022
…ture After containers/image#220, and especially future containers/image#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/distribution/reference.ParseNamednow (as of 6170ac53daed40ebbebc9fe5f482495d01f09f12) refuses input in a non-fully-explicit form; the newParseNormalizedNamedaccepts it and normalizes it into the fully explicit form. (One would expect it to be the other way around…)So, use
ParseNormalizedNamednow. This is a minimal fix for the failing tests.Because
docker/distribution/referencenow does all the normalization, we can use it and drop ourdocker/docker/referencefork (which will go away upstream), at least in the short term. (Longer-term we may need to reintroduce it again ifprojectatomic/dockerdecided to modify that.) But that’s more than just fixing the tests, so that will be a separate PR.