docker: fixup requests authentication #210
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's totally wrong to rely on the
WWW-Authenticateheader fromping-gcr.iofor instance always return 401 on/v2/but that doesn't mean all repos need auth.This patch clean up a bit this situation by not reading the auth header from ping (nor storing it anywhere in the docker client).
From now on, each request will be challenged for authentication needs (which is probably what the docker client does as well, otherwise I cannot see how this would be possible :))
@mtrmac PTAL? For more background and if I missed anything else: https://bugzilla.redhat.com/show_bug.cgi?id=1413987
Signed-off-by: Antonio Murdaca [email protected]