Skip to content

[release-5.26] Bump c/storage to 1.48.1, c/image to 5.26.2 and 5.26.3-dev #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TomSweeneyRedHat
Copy link
Member

Bump c/storage to 1.48.1
Bump c/image to 5.26.2
Bump c/image to 5.26.3-dev

in preparation for RHEL 8.9/9.3 final freeze

[NO NEW TESTS NEEDED]

Bump c/storage to v1.48.1 in preparation of the final RHEL 8.9/9.3
release.

[NO NEW TESTS NEEDED]

Signed-off-by: TomSweeneyRedHat <[email protected]>
As the title says.

[NO NEW TESTS NEEDED]
Signed-off-by: TomSweeneyRedHat <[email protected]>
As the title says

[NO NEW TESTS NEEDED]

Signed-off-by: TomSweeneyRedHat <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I don´t think this bump is necessary. Consumers of c/storage can just bump c/storage directly. So we only need to bump skopeo, buildah and podman and can ignore image and common.

@TomSweeneyRedHat
Copy link
Member Author

@vrothberg @rhatdan @mtrmac could I have a LGTM (or two) and merge on this please? This is part of this weeks vendor dance for RHEL 8.9/9.3

@vrothberg
Copy link
Member

@TomSweeneyRedHat please see my comment above

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 23, 2023

@TomSweeneyRedHat @vrothberg I don’t care either way. It’s extra work and it’s not necessary for the consumers, but dependency-only minor version bumps are not unheard of, almost all the work has been already done, and keeping the process consistent is a bit valuable to help guide future cases.

I’ll leave at least an hour more for discussion in case there are other arguments — tentatively I’m thinking of merging this.

@vrothberg
Copy link
Member

It won't hurt too merge, so I'll go ahead. My main point is that we don't need it technically and that it makes the vendor dance longer than needed.

@vrothberg vrothberg merged commit 52799c1 into containers:release-5.26 Aug 23, 2023
@TomSweeneyRedHat
Copy link
Member Author

Thanks @mtrmac and @vrothberg . I'm admitedly a little OCD about this, but I like to have the numbers all fresh at the start of a new RHEL release. Thanks for putting up with the quirks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants