Formally require Go 1.15 #1493
Merged
Formally require Go 1.15 #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mtrmac could you rebase just to be sure everything's in order? |
mtrmac
force-pushed
the
go-1.15
branch
3 times, most recently
from
aa91955 to
cfc719b
Compare
Collaborator
Author
|
Rebased, tests pass. |
Member
|
LGTM |
Member
|
/lgtm |
Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
…ccept an *url.URL This is, sadly, wasteful, because NewRequestWithContext() only accepts a string and parses it again, but it gives us more type safety, and simplifies at least some callers. Most importantly, this will also allow us to call url.Redacted() for logging. Signed-off-by: Miloslav Trmač <[email protected]>
... to be at least a bit protected against credentials in logs. I did try to find all uses, but it's possible I have missed some. Signed-off-by: Miloslav Trmač <[email protected]>
... to simplify tests. Signed-off-by: Miloslav Trmač <[email protected]>
We no longer need a cleanup callback. Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do that in practice:
so make that official to possibly benefit from that.
Then adopt various newly available API; see the individual commits for details.