Reorganize storageImageDestination to prioritize the private …WithOptions methods #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that it isn't in the middle of the PutBlob implementation. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
…estination.PutBlob For now this is just an alias, but we will want to remove the public PutBlob implementation (in favor of using a generic compat wrapper). Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
... allowing this to be replaced with a generic stub later. Signed-off-by: Miloslav Trmač <[email protected]>
... so that it isn't in the middle of TryReusingBlob. Signed-off-by: Miloslav Trmač <[email protected]>
It will be the primary internal "locked" implementation point, we don't want to implement TryReusingBlob as a stack of calls, each WithOneMember implementing only that OneMember. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
... just like its caller tryReusingBlobAsPending Signed-off-by: Miloslav Trmač <[email protected]>
... so that tryReusingBlobAsPending and tryReusingBlobLocked are consecutive. We will merge the two (and TryReusingBlob will go away completley, eventually). Signed-off-by: Miloslav Trmač <[email protected]>
When options.SrcRef and options.LayerIndex is not set, it amounts to the same thing. Signed-off-by: Miloslav Trmač <[email protected]>
It's the only caller now, and the semantics of "Locked" vs. "AsPending" is hard to describe; just have one larger function that does all kinds of lookups. If it turns out to be too large, we can split it to individual lookups, instead of having the SrcRef case treated as uniquely special. Signed-off-by: Miloslav Trmač <[email protected]>
... to avoid copies. Keep the interfaces in terms of struct values, to make the value semantics explicit (and maybe to help the compiler a bit to show that the data doesn't need to be on a heap). Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
storage-private-primary
branch
from
e86315f to
4da6615
Compare
Collaborator
Author
|
(Tests pass now, after a Skopeo CI fix.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #1439 : modify
storageImageDestinationso thatPutBlobis just a trivial wrapper overPutBlobWithOptions, andTryReusingBlobis just a trivial wrapper overTryReusingBlobWithOptions.Later we’ll replace those wrappers with uses of universally-usable adapters.