sif: initial sif transport implementation #1436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yannick Cote <[email protected]>
Bring sif code in the repo instead of pulling it in at build time. Resolves PR code review discussion. Signed-off-by: Yannick Cote <[email protected]>
Signed-off-by: Yannick Cote <[email protected]>
Signed-off-by: Yannick Cote <[email protected]>
Signed-off-by: Adam Hughes <[email protected]>
Signed-off-by: Adam Hughes <[email protected]>
Collaborator
|
Thanks! I have included this work in #1438 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial SIF transport introduced by @yhcote in #1402, adapted to use upstream SIF implementation (as requested here).
Includes change to use
OptLoadWithFlag(os.O_RDONLY)as suggested in #1402 (comment).