Remove copy.Options.FetchPartialBlobs #1321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and enable the option by default. Now that it is enabled by default, the option can't be used to opt out because we can't distinguish between "unset" and "opt out"; so we would need a different option to support opt outs anyway. This is technically an API break, which we try really hard not to do, but it was in a published release only for 7 days, has no known users, and it was documented as experimental, so hopefully we can get away with it. Signed-off-by: Miloslav Trmač <[email protected]>
Collaborator
Author
|
Closing in favor of #1320. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and enable the option by default. Now that it is enabled by default, the option can't be used to opt out because we can't distinguish between "unset" and "opt out"; so we would need a different option to support opt outs anyway.
This is technically an API break, which we try really hard not to do, but it was in a published release only for 7 days,
has no known users, and it was documented as experimental, so hopefully we can get away with it.
@giuseppe RFC