Use quay.io in docker unit tests instead of docker.io #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Member
|
LGTM also. Those images we copied to quay are used by nearly all of our CI everywhere and everybody understands not to touch them :D The test-failures here will go away after we synchronize the "skopeo_test" task to the new c/skopeo version... |
Member
|
...rebase and this will fix the skopeo tests: #1309 |
Member
|
LGTM |
Member
Ya it's a known issue, rebase will indeed fix it. |
... to avoid docker.io pull limits. NewImageSource and NewImage actually access the remote server (because NewImageSource is looking for a working mirror); update NewImageDestination basically for symmetry. Signed-off-by: Miloslav Trmač <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to avoid docker.io pull limits.
NewImageSourceandNewImageactually access the remote server (becauseNewImageSourceis looking for a working mirror); updateNewImageDestinationbasically for symmetry.