Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Oct 12, 2016

Instead of that big json, reuse docker/distribution registry errors since we are already used by that in Docker. This change isn't a big deal but at least I got tests working in projectatomic/docker#200 and errors are much much nicer with skopeo:

$ ./skopeo inspect docker://runcom/doesnotexist
FATA[0001] manifest unknown: manifest unknown

$ ./skopeo inspect docker://asdasd
FATA[0002] unauthorized: authentication required

Note those errors above are the same docker print out.

This is a blocker for projectatomic/docker#200 because w/o this we don't have any way/mapping to tell docker to fallback to v1 and we end up breaking docker.

@mtrmac PTAL

@baude @aweiteka sort of related to projectatomic/atomic#636

Signed-off-by: Antonio Murdaca [email protected]

@runcom
Copy link
Member Author

runcom commented Oct 12, 2016

@glestaris PTAL since you exported that ErrFetchManifest but you can now use finer grained errors from docker/distribution

@runcom
Copy link
Member Author

runcom commented Oct 12, 2016

skopeo's PR to fix tests containers/skopeo#232

@mtrmac
Copy link
Collaborator

mtrmac commented Oct 12, 2016

👍

Approved with PullApprove

@runcom runcom merged commit b6aaec4 into containers:master Oct 12, 2016
@runcom runcom deleted the better-errors branch October 12, 2016 12:45
@glestaris
Copy link
Contributor

@runcom thanks for the heads up! We got it bumpbed yesterday cloudfoundry/grootfs@0d2ed86 :)

giuseppe pushed a commit to giuseppe/image that referenced this pull request Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants