types: add DockerRegistryUserAgent to SystemContext #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
👍 assuming tests pass |
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
reg-user-agent
branch
from
81a2873 to
20b348e
Compare
Member
Author
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package users may want to identify themselves with the registry for tracking purpose (as Docker engine is doing). This patch adds a new field to
types.SystemContextcalledDockerRegistryUserAgentwhich if not empty is added as anUser-Agentheader to each request to the registry.@mtrmac PTAL, this is needed for projectatomic/docker#200 and it's blocking it since docker's integration tests are failing w/o this.
Signed-off-by: Antonio Murdaca [email protected]