Skip to content

docker: fork docker/docker/reference pkg #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
runcom merged 1 commit into from
Oct 11, 2016
Merged

docker: fork docker/docker/reference pkg #123

runcom merged 1 commit into from
Oct 11, 2016

Conversation

@runcom
Copy link
Member

@runcom runcom commented Oct 10, 2016 •
edited
Loading

As discussed into #99

@mtrmac PTAL, making a PR for skopeo check if everything's ok over there. I'll check with projectatomic/docker#200 as well.

Signed-off-by: Antonio Murdaca [email protected]

@runcom runcom mentioned this pull request Oct 10, 2016
Merged
@runcom runcom changed the title docker: fork docker/dockerreference pkg docker: fork docker/docker/reference pkg Oct 10, 2016
@runcom
Copy link
Member Author

runcom commented Oct 10, 2016

This seems to be working fine in projectatomic/docker#200

@runcom runcom mentioned this pull request Oct 10, 2016
Merged
@mtrmac
Copy link
Collaborator

mtrmac commented Oct 11, 2016

Seems fine, but uncertain with tests failing.

@mtrmac
Copy link
Collaborator

mtrmac commented Oct 11, 2016

containers/skopeo#229 (comment) , though:

This seems to pull in way too much, including a pretty big part of docker/distribution. IIRC in the earlier instance of forking docker/docker/reference we have eliminated the uses of docker/docker/image to not pull in so much.

@runcom
Copy link
Member Author

runcom commented Oct 11, 2016

his seems to pull in way too much, including a pretty big part of docker/distribution. IIRC in the earlier instance of forking docker/docker/reference we have eliminated the uses of docker/docker/image to not pull in so much.

I can definitely do that 👍

@runcom runcom force-pushed the fork-docker-reference branch 3 times, most recently from 8eaff0b to dec5d87 Compare October 11, 2016 13:44
@runcom
Copy link
Member Author

runcom commented Oct 11, 2016

@mtrmac done and tests fixed into containers/skopeo#229 - can you ack this and containers/skopeo#229 ?

@runcom
Copy link
Member Author

runcom commented Oct 11, 2016 •
edited
Loading

lgtm

Approved with PullApprove

@glestaris
Copy link
Contributor

glestaris commented Oct 11, 2016

This is amazing! One less dependency to the docker/docker repository (#54). We've been looking forward to dropping the docker/docker dependency (given how chunky it is) :)

@mtrmac
Copy link
Collaborator

mtrmac commented Oct 11, 2016 •
edited by runcom
Loading

👍 thanks! It is pretty amazing how much that allowed us to get rid of.

Approved with PullApprove

@mtrmac
Copy link
Collaborator

mtrmac commented Oct 11, 2016

(Do fix the formatting which breaks the tests, though.)

@runcom runcom force-pushed the fork-docker-reference branch from dec5d87 to 6021224 Compare October 11, 2016 14:53
@runcom
Copy link
Member Author

runcom commented Oct 11, 2016

(Do fix the formatting which breaks the tests, though.)

done, I'll merge after tests

@runcom runcom merged commit 34fbdd4 into containers:master Oct 11, 2016
@runcom runcom deleted the fork-docker-reference branch October 11, 2016 15:21
@mtrmac mtrmac mentioned this pull request Jan 20, 2017
Merged
giuseppe pushed a commit to giuseppe/image that referenced this pull request Jan 24, 2017
@runcom
Merge pull request containers#123 from duglin/modBuild
6d7c93a 
Build binary in a docker container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@runcom @mtrmac @glestaris