Support man page formatting #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
requested changes
Oct 5, 2016
Collaborator
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Most importantly, please add a Signed-off-by to fix the failing tests.
signature/policy_types.go
Outdated
| @@ -1,4 +1,5 @@ | |||
| // Note: Consider the API unstable until the code supports at least three different image formats or transports. | |||
| // Keep this in sync with documentation | |||
Collaborator
There was a problem hiding this comment.
policy_types.go has nothing to do with registries.d. The relevant comment already is in https://github.com/containers/image/blob/master/docker/lookaside.go#L28 .
docs/registries.d.md
Outdated
| <!-- NOTE: Keep this in sync with signature/policy_types.go! --> | ||
|
|
||
| % REGISTRIES.D(5) Registries.d Man Page | ||
| % Miloslav Trmac |
Collaborator
There was a problem hiding this comment.
Trmač , please (in both places)
aweiteka
force-pushed
the
man-format-docs
branch
from
d4bd5f7 to
f9631a9
Compare
Signed-off-by: Aaron Weitekamp <[email protected]>
aweiteka
force-pushed
the
man-format-docs
branch
from
f9631a9 to
20ba448
Compare
Contributor
Author
Member
|
lgtm |
mtrmac
approved these changes
Oct 14, 2016
Collaborator
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide basic formatting markup so md2man renders properly.
@mtrmac please review