Skip to content

main: if the path is a dir, work on the proc path #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhatdan merged 2 commits into from
Aug 16, 2019
Merged

main: if the path is a dir, work on the proc path #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08136d8
main: if the path is a dir, work on the proc path
giuseppe Aug 15, 2019
9e110ad
main, listxattr: open the file in read only mode
giuseppe Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ dist: xenial
addons:
apt:
packages:
- attr
- automake
- autotools-dev
- git
Expand Down
4 changes: 2 additions & 2 deletions main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ open_fd_or_get_path (struct ovl_data *lo, struct ovl_node *n, char *path, int *f
path[0] = '\0';

*fd = TEMP_FAILURE_RETRY (openat (node_dirfd (n), n->path, O_NONBLOCK|O_NOFOLLOW|mode));
if (*fd < 0 && errno == ELOOP)
if (*fd < 0 && (errno == ELOOP || errno == EISDIR))
{
get_node_path (lo, n, path);
return 0;
Expand Down Expand Up @@ -2038,7 +2038,7 @@ ovl_listxattr (fuse_req_t req, fuse_ino_t ino, size_t size)
}

path[0] = '\0';
ret = open_fd_or_get_path (lo, node, path, &fd, O_WRONLY);
ret = open_fd_or_get_path (lo, node, path, &fd, O_RDONLY);
if (ret < 0)
{
fuse_reply_err (req, errno);
Expand Down
6 changes: 6 additions & 0 deletions tests/fedora-installs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,11 @@ fuse-overlayfs -o fast_ino_check=1,sync=0,lowerdir=lower,upperdir=upper,workdir=

docker run --rm -ti -v $(pwd)/merged:/merged centos:6 yum --installroot /merged -y --releasever 6 install nano

mkdir merged/a-directory

setfattr -n user.foo -v bar merged/a-directory
getfattr -d merged/a-directory | grep bar
getfattr --only-values -n user.foo merged/a-directory | grep bar
getfattr --only-values -n user.foo upper/a-directory | grep bar

umount merged