Closed
Conversation
Member
|
tests are failing |
hswong3i
force-pushed
the
master-linux-amd64
branch
2 times, most recently
from
65b64d3 to
bd1f35c
Compare
Contributor
Author
|
@giuseppe @saschagrunert similar as cri-o/cri-o#4630 (comment), |
Member
|
It seems to fail on arm64, not amd64. Or am I missing anything? |
Contributor
Author
Yes, the build only failed for arm64, amd64 is fine. |
Member
|
@hswong3i had a chance to look at this again? |
Member
|
Looks like this is the patch we have to wait for: NixOS/nixpkgs#117914 |
hswong3i
force-pushed
the
master-linux-amd64
branch
2 times, most recently
from
d502508 to
449df01
Compare
Contributor
Author
|
@saschagrunert I fix the |
hswong3i
force-pushed
the
master-linux-amd64
branch
from
449df01 to
b445f77
Compare
hswong3i
force-pushed
the
master-linux-amd64
branch
4 times, most recently
from
475d26b to
6aa7e3c
Compare
hswong3i
force-pushed
the
master-linux-amd64
branch
2 times, most recently
from
1ff0dd6 to
c048460
Compare
hswong3i
force-pushed
the
master-linux-amd64
branch
3 times, most recently
from
925f9cb to
527a99a
Compare
Contributor
Author
|
@saschagrunert may this PR have your kindly review and approval? |
Member
|
The static build is still failing. |
Contributor
Author
Error from build log (see https://github.com/containers/crun/pull/618/checks?check_run_id=2515014267) show that it is related to aarch64-linux but not x86_64-linux. My local build for x86_64-linux is totally fine without any error :-S @saschagrunert aarch64-linux support seems introduced by 8d0ebf6, would you mind to fix it onward? |
hswong3i
force-pushed
the
master-linux-amd64
branch
3 times, most recently
from
c106b6b to
f5295d3
Compare
Member
I'd prefer fixing it before merging this PR. |
Contributor
Author
|
@saschagrunert with updated to Any hints or idea? |
Contributor
Author
|
ok this line from NixOS/nixpkgs@5f8a741 generate the glib problem for systemd (https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/systemd/default.nix#L328): Simply hard-code it as |
hswong3i
force-pushed
the
master-linux-amd64
branch
9 times, most recently
from
62c00b7 to
06ee575
Compare
Member
|
is m4 not installed? |
Contributor
Author
I also did a try to manually install Here are the diff in between, with no specific handling for m4 at amd64: $ diff -urpNwbB nix/default.nix nix/default-arm64.nix
--- nix/default.nix 2021-06-09 22:03:46.723085852 +0800
+++ nix/default-arm64.nix 2021-06-09 22:03:46.723085852 +0800
@@ -1,9 +1,11 @@
-{ system ? builtins.currentSystem, enableSystemd ? true }:
+{ enableSystemd ? true }:
let
pkgs = (import ./nixpkgs.nix {
+ crossSystem = {
+ config = "aarch64-unknown-linux-gnu";
+ };
config = {
packageOverrides = pkg: {
- criu = (static pkg.criu);
gpgme = (static pkg.gpgme);
libassuan = (static pkg.libassuan);
libgpgerror = (static pkg.libgpgerror);
@@ -29,7 +31,7 @@ let
configureFlags = [
"--enable-confdir=/etc"
"--enable-usbdropdir=/var/lib/pcsc/drivers"
- "--with-systemdsystemunitdir=${placeholder "bin"}/lib/systemd/system"
+ "--disable-libsystemd"
];
buildInputs = [ pkgs.python3 pkgs.udev pkgs.dbus pkgs.systemd ];
});
@@ -76,7 +78,7 @@ let
enableParallelBuilding = true;
outputs = [ "out" ];
nativeBuildInputs = [ autoreconfHook bash gitMinimal pkg-config python3 which ];
- buildInputs = [ glibc glibc.static glib criu libcap libseccomp protobufc systemd yajl ];
+ buildInputs = [ glibc glibc.static glib libcap libseccomp protobufc systemd yajl ];
configureFlags = [ "--enable-static" ]
++ lib.optional (!enableSystemd) [ "--disable-systemd" ];
prePatch = ''
@@ -84,7 +86,7 @@ let
export LDFLAGS='-s -w -static-libgcc -static'
export EXTRA_LDFLAGS='-s -w -linkmode external -extldflags "-static -lm"'
export CRUN_LDFLAGS='-all-static'
- export LIBS='${criu}/lib/libcriu.a ${glibc.static}/lib/libc.a ${glibc.static}/lib/libpthread.a ${glibc.static}/lib/librt.a ${lib.getLib libcap}/lib/libcap.a ${lib.getLib libseccomp}/lib/libseccomp.a ${protobufc}/lib/libprotobuf-c.a ${protobuf}/lib/libprotobuf.a ${lib.getLib systemd}/lib/libsystemd.a ${yajl}/lib/libyajl_s.a'
+ export LIBS='${glibc.static}/lib/libc.a ${glibc.static}/lib/libpthread.a ${glibc.static}/lib/librt.a ${lib.getLib libcap}/lib/libcap.a ${lib.getLib libseccomp}/lib/libseccomp.a ${protobufc}/lib/libprotobuf-c.a ${protobuf}/lib/libprotobuf.a ${lib.getLib systemd}/lib/libsystemd.a ${yajl}/lib/libyajl_s.a'
'';
buildPhase = ''
patchShebangs . |
hswong3i
force-pushed
the
master-linux-amd64
branch
3 times, most recently
from
b0a0d5b to
578de62
Compare
Member
|
@hswong3i Is the artifact failure a problem? |
hswong3i
force-pushed
the
master-linux-amd64
branch
2 times, most recently
from
45784eb to
cbb7c22
Compare
- Bugfix `make nixpkgs` which pin with branch `nixos-21.05` - Code lint with `nixpkgs-fmt` - Code sync between x86\_64 and aarch64 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
force-pushed
the
master-linux-amd64
branch
from
cbb7c22 to
e4d7d9a
Compare
Member
|
@hswong3i Still not working? |
Contributor
Author
|
I am moving my Ansible Role to using kubic repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make nixpkgswhich pin with branchnixos-21.05nixpkgs-fmtSigned-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com