Re-enable vendoring

[jankaluza]

The Renovate PR to support top-level vendor directory is merged and should be deployed in the production.

It should be safe to re-enable the vendoring now.

[jankaluza]

This is an example of Renovate PR opened in my fork with this PR applied: jankaluza#2

[jankaluza]

Second commit skips the codespell for the ./vendor.

[Luap99]

Need to update the Makefiles to rename tidy to vendor and do the go work vendor step in the Makefiles and I guess we want the go work sync as well added to the top level Makefile. And then update the go-tidy github action to run the make vendor instead

[jankaluza]

@Luap99 , done in the third commit. I also renamed the tidy-in-container to vendor-in-container, but I did not find any place where this is executed - probably only manually?

[Luap99]

LGTM, @mtrmac PTAL

[mtrmac]

Thanks, makes sense overall.

(For the record, AFAICT we need the vendor step because Renovate only does go work sync if vendoring is enabled, per #291 (comment) .)

[mtrmac]

Apples in all 3 modules: The net effect is that a top-level make vendor would run go work vendor three times. That seems unnecessary (and from a quick local check, repeated go work vendor is not faster than the first run, so this is a ~real cost, although measured in single seconds).

Maybe keep the tidy goals in the subprojects, and only turn the top-level tidy into vendor.

[jankaluza]

So, I've kept the tidy in projects' Makefiles. The top-level Makefile has the vendor target now.

[jankaluza]

I also had to disable the git-validation for the ./vendor directory, otherwise it failed for some trailing white-spaces in the files in the ./vendor directory which are out of our control. This is done in the last commit.