common: no slirp for podman6 #393
Open
+149
−1,639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Packit jobs failed. @containers/packit-build please check. |
lsm5
force-pushed
the
podman6-no-slirp
branch
from
57c62b9 to
92c00a9
Compare
Luap99
added
the
podman 6
lsm5
force-pushed
the
podman6-no-slirp
branch
2 times, most recently
from
db2cffc to
90bb692
Compare
Replace with cgroups.IsCgroup2UnifiedMode. Signed-off-by: Lokesh Mandvekar <[email protected]>
And all the cgroup v1 logic that relied on the cgroup2 bool Signed-off-by: Lokesh Mandvekar <[email protected]>
- exclude param from getAvailableControllers - cgroupV1GetAllSubsystems - CgroupControl.createGroupDirectory - readAcct - readAcctList Signed-off-by: Lokesh Mandvekar <[email protected]>
Also inline some struct element values with constant values Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
I can only see it being called in libpod/oci_conmon_linux.go that too when CgroupManager is not systemd, so it should be safe to remove. Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Also rename systemd.MoveRootlessNetnsSlirpProcessToUserSlice to systemd.MoveRootlessNetnsProcessToUserSlice. Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
podman6-no-slirp
branch
from
90bb692 to
49f1c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.