Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update golangci-lint to v1.64.4 #2323

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

update golangci-lint to v1.64.4 #2323

wants to merge 6 commits into from

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Feb 13, 2025

see commits

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtrmac
mtrmac reviewed Feb 13, 2025
View reviewed changes
libimage/manifest_list_test.go Show resolved Hide resolved
libimage/runtime_test.go Outdated Show resolved Hide resolved
libimage/runtime_test.go Outdated Show resolved Hide resolved
libnetwork/slirp4netns/slirp4netns.go Outdated Show resolved Hide resolved
pkg/cgroups/cgroups_linux.go Outdated Show resolved Hide resolved
.github/renovate.json5 Show resolved Hide resolved
mtrmac
mtrmac reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits, LGTM otherwise.

libnetwork/slirp4netns/slirp4netns.go Outdated Show resolved Hide resolved
pkg/cgroups/cgroups_linux.go Outdated Show resolved Hide resolved
libimage/runtime_test.go Outdated Show resolved Hide resolved
@Luap99
use std maps package where possible
e1f5ada 
Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
fix issues reported by errcheck
eed7689 
Mainly type casting issues. I ignored some of them where I don't think
it can fail or when it is in tests where we would notice anyway.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
fix issues reported by usetesting
9813355 
In particular rework the tmpdir test to use two seperate runs so we can
correctl use t.Setenv() so it cleans up at the right moment.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
fix issue reported by recvcheck
c8e943a 
Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
update golangci-lint to v1.64.4
7e5fdcd 
Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
renovate: teach it to update the lint version
9378a51 
Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luap99 @mtrmac