Ensure that rootless cgroupsv1 will select cgroupfs #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhatdan @vrothberg @giuseppe PTAL |
The current logic is that, if Podman was built with the systemd build flag, we will always select systemd cgroups by default. Then, if we detect no systemd dbus session, we will swap to cgroupfs. Problem: there are cases where a systemd dbus session is available, but systemd cgroups don't work - most notably, rootless mode on cgroups v1 systems. Special-case this so that we will not try to force systemd mode and break rootless containers. Fixes containers/podman#6982 Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
fix_rootless_systemd
branch
from
aea7bf8 to
a61c5e2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: giuseppe, mheon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic is that, if Podman was built with the systemd build flag, we will always select systemd cgroups by default. Then, if we detect no systemd dbus session, we will swap to cgroupfs. Problem: there are cases where a systemd dbus session is available, but systemd cgroups don't work - most notably, rootless mode on cgroups v1 systems. Special-case this so that we will not try to force systemd mode and break rootless containers.
Fixes containers/podman#6982