Make the definition of LookupReferenceFunc unconditional

[nalind]

Move the definition of our LookupReferenceFunc type alias to a file that isn't conditionally compiled, as an alternative to containers/buildah#5628.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[rhatdan]

LGTM

[rhatdan]

@Luap99 @mheon @lsm5 @edsantiago @flouthoc PTAL

[mheon]

Sure
/lgtm

[aaronlehmann]

Does this address the bloat issue mentioned in containers/buildah#5532 (comment)?

[mheon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

I believe pulling in common/libimage/manifest versus pulling common/libimage should fix it.

[nalind]

Does this address the bloat issue mentioned in containers/buildah#5532 (comment)?

When I look at the go list -deps output for versions of github.com/containers/buildah/define that use libimage.LookupReferenceFunc and manifests.LookupReferenceFunc, the version that uses the definition from manifests has fewer dependencies. Maybe I shouldn't have closed containers/buildah#5628?