Skip to content

Remove slirp for Podman6 #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Remove slirp for Podman6 #6443

wants to merge 5 commits into from

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 21, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

For podman6

How to verify it

Verify buildah doesn't work with slirp

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Slirp4netns support has been removed.

Rebased on the cgroups v1 removal PR.

@lsm5 lsm5 added the podman 6 breaking changes that should only go into podman 6 label Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lsm5 added 2 commits October 21, 2025 12:00
@lsm5
vendor update
ff29e89 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Remove Cgroups v1 support (podman6)
7735e61 
Fixes: RUN-3567 (partly)

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the podman6-no-slirp branch from c0c824d to d14aa61 Compare October 21, 2025 16:01
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 added 3 commits October 21, 2025 14:11
@lsm5
Remove slirp for podman6
b79e6f7 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
tests: Remove slirp for podman6
aab6673 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
docs: Remove slirp for podman6
9374d7f 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the podman6-no-slirp branch from d14aa61 to 9374d7f Compare October 21, 2025 18:11
@nalind
Copy link
Member

nalind commented Oct 22, 2025

Does this include the changes from #6424?

@lsm5
Copy link
Member Author

lsm5 commented Oct 23, 2025

Does this include the changes from #6424?

I think so. I might need to rebase on main though. Also, one of the crun tests timed out. I retriggered it just now.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved do-not-merge/work-in-progress needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. podman 6 breaking changes that should only go into podman 6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsm5 @nalind @openshift-merge-robot