Introduce CommitResults(), add --metadata-file #6442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/feature
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Member
|
Quick breeze review looks good, but all kinds of red unhappiness in the tests. |
Rename the Executor and StageExecutor types to make them private to the package. Exporting them wasn't required for them to supply an interface that they implemented for use by github.com/openshift/imagebuilder, and we're about to change the signature for StageExecutor.Execute(). Signed-off-by: Nalin Dahyabhai <[email protected]>
Add a CommitResults() method which returns a structure on success, changing Commit() into a wrapper for it which returns a subset of the data to keep its signature stable. Signed-off-by: Nalin Dahyabhai <[email protected]>
Add a MetadataFile field to BuildOptions, to which we write a dictionary of information about a just-committed image. Pay more attention to sourceDateEpoch than to timestamp when we're tagging an existing image with the intended destination name. Signed-off-by: Nalin Dahyabhai <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a CommitResults() method that returns a structure with information, to make it easier to extend.
Use it to add a
--metadata-fileflag tobuildah commitandbuildah build.How to verify it
New and updated integration tests!
Which issue(s) this PR fixes:
Fixes #6428.
Special notes for your reviewer:
Does this PR introduce a user-facing change?