Add some validation checks #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalind
force-pushed
the
validate
branch
30 times, most recently
from
f98c21e to
4be9e8e
Compare
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 11, 2017
Fix a number of issues flagged by golint. Signed-off-by: Nalin Dahyabhai <[email protected]> Closes: #62 Approved by: rhatdan
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 11, 2017
Fix a number of issues flagged by gometalinter. Signed-off-by: Nalin Dahyabhai <[email protected]> Closes: #62 Approved by: rhatdan
Collaborator
|
💔 Test failed - status-redhatci |
This is a placeholder commit that tests/validate/git-validation.sh will use as a starting commit for running its checks outside of CI. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
validate
branch
2 times, most recently
from
e5d9326 to
7682abf
Compare
Add a "validate" target to the top level Makefile that checks formatting of source files with golint, signed-off-by tags with git-validate, and for various other warnings with gometalinter. Signed-off-by: Nalin Dahyabhai <[email protected]>
Fix a number of issues flagged by golint. Signed-off-by: Nalin Dahyabhai <[email protected]>
Fix a number of issues flagged by gometalinter. Signed-off-by: Nalin Dahyabhai <[email protected]>
Member
Author
|
@rh-atomic-bot retry |
Member
Author
|
Reworked some of the install targets to merge install-tools and .install.md2man and avoid having "make all" install things outside of the build tree. |
Remove "install.tools" as a dependency of the top-level "all" target, and make it a dependency of the "install" target. Signed-off-by: Nalin Dahyabhai <[email protected]>
Member
Author
|
@TomSweeneyRedHat, @rhatdan, PTAL again for that last patch, which is kind of small to be on its own, since we're already messing around with the top-level Makefile. |
Member
Collaborator
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 12, 2017
Fix a number of issues flagged by golint. Signed-off-by: Nalin Dahyabhai <[email protected]> Closes: #62 Approved by: rhatdan
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 12, 2017
Fix a number of issues flagged by gometalinter. Signed-off-by: Nalin Dahyabhai <[email protected]> Closes: #62 Approved by: rhatdan
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 12, 2017
Remove "install.tools" as a dependency of the top-level "all" target, and make it a dependency of the "install" target. Signed-off-by: Nalin Dahyabhai <[email protected]> Closes: #62 Approved by: rhatdan
Collaborator
|
☀️ Test successful - status-redhatci |
nalind
pushed a commit
that referenced
this pull request
Nov 28, 2017
Signed-off-by: Urvashi Mohnani <[email protected]> Closes: #62 Approved by: rhatdan
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks using gofmt, gometalinter, and git-validate, and fixup the things that they flag.