Broaden what "rmi" can accept, and add tests #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach "rmi" to handle arbitrary image references and incomplete references, and add tests for both. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
referenced
this pull request
Mar 29, 2017
Rename the "list" and "delete" commands to "containers" and "rm", respectively, and add "images" and "rmi" counterparts for them. Signed-off-by: Nalin Dahyabhai <[email protected]> Closes: #32 Approved by: rhatdan
Member
|
Will this handle truncated ID's? |
Member
Collaborator
|
🙀 |
Member
Author
|
Truncated IDs should work as soon as we get containers/storage#6, or something like it in. |
Member
Author
|
@rh-atomic-bot retry |
Member
Collaborator
Collaborator
|
☀️ Test successful - status-redhatci |
nalind
pushed a commit
that referenced
this pull request
Nov 28, 2017
Users of kpod run could use these file systems to perform a breakout or to learn valuable system information. Signed-off-by: Daniel J Walsh <[email protected]> Closes: #61 Approved by: mheon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach "rmi" to handle arbitrary image references and image references that implicitly refer to the local store, and add tests for both, falling back to remove-by-ID for anything left after we finish the basic tests. This should fix the errors in the self-test which currently cause CI to fail for #59.