Add support for images as well as containers to buildah list & delete #47
Conversation
|
Alternative to #32 |
cmd/buildah/delete.go
Outdated
| return fmt.Errorf("error reading build container %q: %v", name, err) | ||
| /* Maybe this was an image attempt to delete it */ | ||
| _, err = store.DeleteImage(name, true) | ||
| return fmt.Errorf("error deleting image or container container %q: %v", name, err) |
There was a problem hiding this comment.
"container container"?
This patch set will cleanup the output of buildah list adding truncate flags as well as support images.
| if len(images) > 0 && !quiet { | ||
| fmt.Printf("\nIMAGES\n\n") | ||
| if truncate { | ||
| fmt.Printf("%-12s %-64s\n", "IMAGE ID", "IMAGE NAME") |
There was a problem hiding this comment.
do you want to do the full 64 for the name or a shorter version here?
There was a problem hiding this comment.
Since we are trying to stay within 80 chars, I thought we would just do 64, also the Name is somewhat important while the ID is pretty much only used by the computer.
We have a bug in this patch in that you can not use the short name for delete operations.
There was a problem hiding this comment.
That's works for me, especially given the bug, I asked because I thought you shortened it at line 93. However i need to read more carefully, you didn't shorten it there either.
TomSweeneyRedHat
left a comment
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
LGTM, just a nit and a question.
|
@nalind PTAL. This one is a little more controversial in that we are expanding the list command to handle both containers and images. |
|
@TomSweeneyRedHat Could you take a look at getting the delete command to handle the short names? |
|
Sure, I'll see what I can mess up with short name deletes. |
|
Will rename buildah list to |
2 participants
This patch set will cleanup the output of buildah list adding truncate
flags as well as support images.