Skip to content

Conversation

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 25, 2017

I chose to only add traditional ones like

--quiet, -q
and
--user -u
And for some which could be specified multiple times I added
-v, -e, -l

listFlags = []cli.Flag{
cli.BoolFlag{
Name: "quiet",
Name: "quiet, q",
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat Mar 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought we were doing 'omit' here to kill the column heading and 'quiet' to show just the id column. fwiw, docker ps --quiet causes it to display only the numeric ids.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me. Basically you want to add an option though correct, since there will still be a quiet option. You just want to change the meaning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd like to add an "omit" option here that would keep the table headers from printing when used. "quiet" would be used to show just the image id's, much like docker does. My main confusion here is I'd thought Nalin had already done this, but perhaps it wasn't merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #32, yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well lets do it here or in a separate pull request.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 27, 2017

@TomSweeneyRedHat I added a --noheading switch and changed quiet to work the way you wanted.

@nalind
Copy link
Member

nalind commented Mar 28, 2017

LGTM.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 28, 2017

@rh-atomic-bot r+ e5fe19c

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit e5fe19c with merge b8214c4...

rh-atomic-bot pushed a commit that referenced this pull request Mar 28, 2017
Add `noheading` option to eliminate headings

Closes: #44
Approved by: rhatdan
@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-redhatci
Approved by: rhatdan
Pushing b8214c4 to master...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants