-
Notifications
You must be signed in to change notification settings - Fork 874
Add some obvious short options #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| listFlags = []cli.Flag{ | ||
| cli.BoolFlag{ | ||
| Name: "quiet", | ||
| Name: "quiet, q", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought we were doing 'omit' here to kill the column heading and 'quiet' to show just the id column. fwiw, docker ps --quiet causes it to display only the numeric ids.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me. Basically you want to add an option though correct, since there will still be a quiet option. You just want to change the meaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'd like to add an "omit" option here that would keep the table headers from printing when used. "quiet" would be used to show just the image id's, much like docker does. My main confusion here is I'd thought Nalin had already done this, but perhaps it wasn't merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #32, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well lets do it here or in a separate pull request.
|
@TomSweeneyRedHat I added a --noheading switch and changed quiet to work the way you wanted. |
Add `noheading` option to eliminate headings
|
LGTM. |
Add `noheading` option to eliminate headings Closes: #44 Approved by: rhatdan
|
☀️ Test successful - status-redhatci |
I chose to only add traditional ones like
--quiet, -q
and
--user -u
And for some which could be specified multiple times I added
-v, -e, -l