Fix use generic/ambiguous DEBUG name #4020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
kind/cleanup
edsantiago
suggested changes
May 26, 2022
cevich
changed the title
cevich
force-pushed
the
fix_debug
branch
3 times, most recently
from
a15fdb1 to
25787b6
Compare
openshift-ci
bot
added
the
needs-rebase
Member
Author
|
Problem with missing |
The use of the generic 'DEBUG' name in varialbes or flags can be very problematic and lead to difficult to troubleshoot problems. Update CI VM images to those including updated automation library that uses the `$A_DEBUG` env. var. instaed. Also update other repository files which make use of the generic form. Signed-off-by: Chris Evich <cevich@redhat.com>
openshift-ci
bot
removed
the
needs-rebase
cevich
changed the title
Member
Author
|
Assuming tests run clean, this should be ready to go. |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The use of the generic 'DEBUG' name in varialbes or flags can be very
problematic and lead to difficult to troubleshoot problems. Update CI
VM images to those which no-longer react to the
$DEBUGenv. var. Alsoupdate other repository files which make use of the generic form.
How to verify it
CI testing and manual review of documentation.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I'm not fully aware of side-effects / consequences of the
Makefileortests/bud/containerfile/Containerfile.inchanges.Does this PR introduce a user-facing change?