Travis: do not use traviswait #1488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The traviswait script has plenty of undesired side-effects, mainly but
not limited to not printing std{err,out} when hitting the time out.
This is especially painful when the tests hit a deadlock, rendering it
useless for debugging the deadlock. Besides that, it also slows down
the tests causing frequent time outs.
Signed-off-by: Valentin Rothberg <[email protected]>
Member
Author
|
@rhatdan @TomSweeneyRedHat @nalind @giuseppe PTAL This has been haunting me a few times in the past 10 days or so but none of the PRs where I added it got merged yet as they are for testing purposes. |
Member
|
LGTM |
Member
|
LGTM |
Member
Collaborator
|
📌 Commit 2f307fc has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - status-papr, status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traviswait script has plenty of undesired side-effects, mainly but
not limited to not printing std{err,out} when hitting the time out.
This is especially painful when the tests hit a deadlock, rendering it
useless for debugging the deadlock. Besides that, it also slows down
the tests causing frequent time outs.
Signed-off-by: Valentin Rothberg [email protected]