Stop vendoring libpod into buildah #1400
Conversation
|
it looks all we need in Buildah from rootless is Let's just duplicate these two functions instead of moving the package. It will be a lot more difficult to fix rootless stuff in Podman if the implementation lives in another repository. |
|
Are the chroot and rootless pkgs also in libpod still? If so could/should we make a new project in containers and vendor them from there? Maybe a jira card for later, it would be nice to untangle this sooner. |
rhatdan
force-pushed
the
storage
branch
2 times, most recently
from
b77c45d to
9816729
Compare
rhatdan
force-pushed
the
storage
branch
3 times, most recently
from
202bbc1 to
bdb7728
Compare
|
bot, retest this please |
|
the error seems related to files that are still under |
|
☔ The latest upstream changes (presumably 939de6f) made this pull request unmergeable. Please resolve the merge conflicts. |
rhatdan
force-pushed
the
storage
branch
3 times, most recently
from
4d40d8a to
e34e041
Compare
|
@giuseppe Yes I need to get this vendored into containers/image first. |
|
☔ The latest upstream changes (presumably d1c75ea) made this pull request unmergeable. Please resolve the merge conflicts. |
rhatdan
changed the title
|
Completes: #1437 |
We don't want to vendor anything from libpod into Buildah. We want to switch this around. Moving pkg content from libpod to Buildah allows us to fix this. Signed-off-by: Daniel J Walsh <[email protected]>
|
We need this PR merged to make others pass again (that vendor recent storage). |
|
LGTM, but would like a head nod from @giuseppe to make sure his rootless concerns are addressed. |
|
On a general note. We should not merge PRs over at containers/storage (or any other place) when breaking the API while the follow-up ones on our consumers are not yet ready. In this specific case we cannot update containers/storage in libpod (and soon in CRI-O) because they depend on buildah which is not yet updated to the API breakages in containers/storage. This does not only block work (in this case me) but also blocks any fixes we might need to perform that require quick vendoring. I think it's more the exception than the rule but I was blocked fairly often by such cases in the past that I want to share my troubles. Especially API breakages should be treated with care and those responsible should do the vendoring into all the consumers. |
|
📌 Commit 9fbc0f3 has been approved by |
|
☀️ Test successful - status-papr, status-travis |
5 participants
These patches remove libpod from buildah and mv some pkg/rootless and pkg/chrootuser from libpod to buildah repo.