Add MS_SILENT to most mount() invocations#377
Merged
cgwalters merged 1 commit intocontainers:masterfrom May 19, 2020
Merged
Conversation
There's an effort to migrate Linux filesystems to handle the y2038 problem, which is great. However, recently a kernel change landed that emits a warning when mounting a filesystem that doesn't handle it, and this notably shows up even when *remounting* e.g. for a read-only bind mount: Using e.g. `rpm-ostree install cowsay` there's a spam of: ``` [ 189.529594] xfs filesystem being remounted at /sysroot supports timestamps until 2038 (0x7fffffff) ``` Now particularly when creating a our bind mounts, let's ask the kernel to be quiet about it. This is not a major event worthy of a kernel log.
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an effort to migrate Linux filesystems to handle the y2038
problem, which is great. However, recently a kernel change landed
that emits a warning when mounting a filesystem that doesn't
handle it, and this notably shows up even when remounting e.g.
for a read-only bind mount:
Using e.g.
rpm-ostree install cowsaythere's a spam of:Now particularly when creating a our bind mounts, let's
ask the kernel to be quiet about it. This is not a major event
worthy of a kernel log.