provide en_US.UTF-8 locale #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A podman test depends on that locale so we need to make it is installed in the image, see containers/podman#19635. Signed-off-by: Paul Holzinger <[email protected]>
|
@cevich PTAL |
cevich
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Changes are fine, looks like a small problem is affecting the debian SID build. I'm not sure what the windows error is (I tried re-running it), hopefully it was a flake.
Confirmed: This was just a flake, the re-run passed. So only the |
Make sure the en_US.UTF-8 LANG is installed and can be used by podman tests, see containers/podman#19635. Signed-off-by: Paul Holzinger <[email protected]>
|
@Luap99 assuming the builds work, do you want me to release the images as an update to all repos? The alternative is you just update the value in podman's |
|
I have to manually update anyway in podman because we should revert this locale fix in the podman setup script. |
|
Cirrus CI build successful. Found built image names and IDs:
|
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Aug 25, 2023
This reverts commit ed1f514. The en_US.UTF-8 locale is now added in the images at build time, containers/automation_images#295 Signed-off-by: Paul Holzinger <[email protected]>
cevich
pushed a commit
to cevich/podman
that referenced
this pull request
Sep 27, 2023
This reverts commit ed1f514. The en_US.UTF-8 locale is now added in the images at build time, containers/automation_images#295 Signed-off-by: Paul Holzinger <[email protected]>
edsantiago
pushed a commit
to edsantiago/libpod
that referenced
this pull request
Sep 28, 2023
This reverts commit ed1f514. The en_US.UTF-8 locale is now added in the images at build time, containers/automation_images#295 Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see containers/podman#19635
wait for the CI there to pass so I know this works