Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix idempotency for RestartPolicy when MaximumRetryCount > 0 #607

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Fix idempotency for RestartPolicy when MaximumRetryCount > 0 #607

merged 1 commit into from
Jul 30, 2023

Conversation

sedrubal
Copy link
Contributor

Before this change, this task:

- containers.podman.podman_container:
    # ...
    restart_policy: on-failure:3
    # ...

always caused this diff:

--- before
+++ after
@@ -1 +1 @@
-restart_policy - on-failure
+restart_policy - on-failure:3

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://review.rdoproject.org/zuul/buildset/222ddb6d1832469281a0af991a02202e

❌ tripleo-ci-centos-9-standalone FAILURE in 9m 35s

@sedrubal
Copy link
Contributor Author

❌ tripleo-ci-centos-9-standalone FAILURE in 9m 35s

I assume, my change does not cause this failure. Tell me, if I'm wrong.

@sshnaidm
Copy link
Member

sshnaidm commented Jul 30, 2023 •
edited
Loading

@sedrubal please commit with -s to make happy DCO job.
This failure is not because of your change, that's right.
Can you think about test for this, btw?
Thanks for contribution!

@sshnaidm
Copy link
Member

check-github

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://review.rdoproject.org/zuul/buildset/32d9640b359a46c3b724b687c19406ad

❌ tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001 NODE_FAILURE Node request 200-0006241071 failed in 0s
❌ tripleo-ci-centos-9-standalone NODE_FAILURE Node request 200-0006241072 failed in 0s
❌ tripleo-ci-centos-9-containers-multinode NODE_FAILURE Node request 200-0006241073 failed in 0s
❌ tripleo-ci-centos-9-undercloud-upgrade NODE_FAILURE Node request 200-0006241074 failed in 0s

Fix idempotency for RestartPolicy when MaximumRetryCount > 0
1da2e24 
Before this change, this task:

```ansible
- containers.podman.podman_container:
    # ...
    restart_policy: on-failure:3
    # ...
```

always caused this diff:

```diff
--- before
+++ after
@@ -1 +1 @@
-restart_policy - on-failure
+restart_policy - on-failure:3
```

Signed-off-by: Sebastian Endres <[email protected]>
@sedrubal sedrubal force-pushed the fix-idempotency-restartpolicy-maximumretrycount branch from 7b972ef to 1da2e24 Compare July 30, 2023 17:29
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://review.rdoproject.org/zuul/buildset/bd7e913e724f4aaeb1bf284cc8c8b203

❌ tripleo-ci-centos-9-standalone NODE_FAILURE Node request 200-0006241448 failed in 0s

@sshnaidm sshnaidm merged commit 0ae6baa into containers:master Jul 30, 2023
21 checks passed
@sedrubal
Copy link
Contributor Author

Thanks for merging. Sorry that I didn't provide a test, but it would cost me to much effort to dig into the tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshnaidm sshnaidm sshnaidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sedrubal @sshnaidm