Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Windows CI (Appveyor) #84

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Enable Windows CI (Appveyor) #84

merged 1 commit into from
Nov 11, 2017

Conversation

rosenhouse
Copy link
Contributor

@rosenhouse rosenhouse commented Nov 1, 2017 •
edited
Loading

Work in progress. DONE!

Windows test output here

@rosenhouse rosenhouse mentioned this pull request Nov 1, 2017
Merged
@rakelkar
Copy link
Contributor

rakelkar commented Nov 1, 2017

@rosenhouse I get an access denied when I click on the detail link above. Maybe need to open up perms on appveyor a bit so that folks can debug build failures?

@rosenhouse
Copy link
Contributor Author

@rakelkar I accidentally enabled the appveyor integration on this repo, but I've removed it now.

to see the appveyor build output for the branch on this PR, click the link I included in my original issue description.

@rosenhouse
Copy link
Contributor Author

Hmm, we seem to be in a chicken & egg scenario here. Host local is breaking on windows here, and you have #77 to make it work on Windows, which I've said is blocked on this.

One option is to continue adding build-tags here. And then later rebase #77 on top of master?

Thoughts?

@rakelkar
Copy link
Contributor

rakelkar commented Nov 1, 2017 via email •
edited
Loading

@rosenhouse rosenhouse mentioned this pull request Nov 1, 2017
Closed
@rosenhouse rosenhouse force-pushed the add-windows-ci branch 2 times, most recently from 8f8fb40 to 1ade2c2 Compare November 8, 2017 07:06
@rosenhouse
Copy link
Contributor Author

ok @rakelkar, @containernetworking/cni-maintainers this is now green on:

  • Travis (Linux)
  • Appveyor (Windows), using a limited set of packages (see plugins/linux_only.txt in the diff)

Please take a look!

Plan for post-merge:

@squeed
Copy link
Member

squeed commented Nov 10, 2017

LGTM.

@rosenhouse
Enable Windows CI (Appveyor)
99f6be0 
- start list of linux_only plugins; ignore them when testing on Windows
- Isolate linux-only code by filename suffix
- Remove stub (NotImplemented) functions
- other misc. fixes for Windows compatibility
rakelkar
rakelkar reviewed Nov 10, 2017
View reviewed changes
plugins/ipam/host-local/backend/disk/lock.go
@@ -1,3 +1,4 @@
// +build !windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+build !windows [](start = 3, length = 15)

what made you include this instead of renaming it to lock_linux.go like you did with the other files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this way the host-local tests can run on my Mac :-)

@rakelkar
Copy link
Contributor

LGTM

@rosenhouse rosenhouse merged commit fbced0c into containernetworking:master Nov 11, 2017
@rakelkar rakelkar mentioned this pull request Nov 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakelkar rakelkar rakelkar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosenhouse @rakelkar @squeed