tuning: Add support of altering the allmulticast flag #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to allow the tuning plugin to enable/disable the allmulticast mode of the interface. When enabled it instructs the network driver to retrieve all multicast packets from the network. Signed-off-by: Björn Svensson <[email protected]>
|
If the PR vishvananda/netlink#635 is merged the import of sys/unix can be avoided, but since the tuning plugin is not amongst the Windows supported plugins (i.e not in |
|
@bjosv this looks good! Can you also file a PR at https://github.com/containernetworking/cni.dev/blob/main/content/plugins/current/meta/tuning.md adding this flag please? |
@squeed Great! Filed the corresponding documentation change in containernetworking/cni.dev#84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to allow the tuning plugin to enable/disable the allmulticast mode of the interface.
When enabled it instructs the network driver to retrieve all multicast packets from the network.
Resolves #621