invoke: capture and return stderr if plugin exits unexpectedly #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Williams <[email protected]>
dcbw
force-pushed
the
really-return-stderr
branch
2 times, most recently
from
9e39109 to
10bca02
Compare
mars1024
reviewed
Apr 8, 2020
squeed
reviewed
Apr 8, 2020
dcbw
force-pushed
the
really-return-stderr
branch
from
10bca02 to
8d2fcf1
Compare
The way raw_exec invokes the command doesn't actually pass back stderr, despite ExitError having that capability. c.Run() internally calls c.Wait() but that doesn't capture stderr and insert it into the returned ExitError. So we have to do that ourselves. Fixes: containernetworking#732 Fixes: containernetworking#759 Signed-off-by: Dan Williams <[email protected]>
dcbw
force-pushed
the
really-return-stderr
branch
from
8d2fcf1 to
44dabed
Compare
squeed
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way raw_exec invokes the command doesn't actually pass back
stderr, despite ExitError having that capability. c.Run()
internally calls c.Wait() but that doesn't capture stderr and
insert it into the returned ExitError. So we have to do that
ourselves.
Fixes: #732
Fixes: #759
@bboreham @squeed @mccv1r0 @containernetworking/cni-maintainers