-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use google.golang.org/protobuf instead of github.com/gogo/protobuf #99
Conversation
ed0e1e5
to
7386e40
Compare
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 72.52% 64.07% -8.46%
==========================================
Files 11 11
Lines 728 899 +171
==========================================
+ Hits 528 576 +48
- Misses 158 278 +120
- Partials 42 45 +3
Continue to review full report at Codecov.
|
ca3da6c
to
039bd6d
Compare
We're looking for this on the K3s side; we need to be able to unpin ttrpc and genproto for #62 (comment) since Kubernetes 1.23+ needs a newer version for custom resource validation via CEL expressions. Really hoping something like this could land in containerd 1.6, or at least be capable of being backported to our forks of 1.6 and/or 1.5. |
712ed9f
to
4cd592b
Compare
This change replaces github.com/gogo/protobuf with google.golang.org/protobuf, except for the code generators. All proto-encoded structs are now generated from .proto files, which include ttrpc.Request and ttrpc.Response. Signed-off-by: Kazuyoshi Kato <[email protected]>
@brandond Sorry. We've released 1.6.0 and this protobuf-related change may be too big to backport. Releasing 1.7.0 relatively earlier may be the only option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Might need some work on compatibility testing.
This change replaces github.com/gogo/protobuf with
google.golang.org/protobuf, except for the code generators.
All proto-encoded structs are now generated from .proto files,
which include ttrpc.Request and ttrpc.Response.
Signed-off-by: Kazuyoshi Kato [email protected]