Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protoc-gen-go-ttrpc #96

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Add protoc-gen-go-ttrpc #96

merged 1 commit into from
Nov 8, 2021

Conversation

kzys
Copy link
Member

@kzys kzys commented Oct 26, 2021

Google's new protobuf code generator only supports protobuf
serialization/deserialization and let other code generators handle
RPC-related aspects.

This new code generator follows the change and can be used with
the new protobuf code generator.

Signed-off-by: Kazuyoshi Kato [email protected]

Google's new protobuf code generator only supports protobuf
serialization/deserialization and let other code generators handle
RPC-related aspects.

This new code generator follows the change and can be used with
the new protobuf code generator.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #96 (6eabacc) into main (58eb91e) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   73.72%   73.58%   -0.15%     
==========================================
  Files          11       11              
  Lines         708      708              
==========================================
- Hits          522      521       -1     
- Misses        149      151       +2     
+ Partials       37       36       -1     
Impacted Files Coverage Δ
server.go 76.92% <0.00%> (-0.74%) ⬇️
client.go 82.32% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eb91e...6eabacc. Read the comment docs.

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Want to get this in to play around with the streaming additions as well.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants